Difference between revisions of "Code Reviewers"

From Lustre Wiki
Jump to navigation Jump to search
(Add reference to MAINTAINERS file and get_maintainer.pl.)
Line 1: Line 1:
 
The following people are willing to perform code reviews on code in the listed sections.
 
The following people are willing to perform code reviews on code in the listed sections.
  
Please add yourself to a section if you are willing to engage in code reviews in the subsection of Lustre code.
+
In Lustre 2.12 and later, the [MAINTAINERS|https://git.whamcloud.com/?p=fs/lustre-release.git;a=blob;f=MAINTAINERS;hb=HEAD] file contains a list of developers that are available for code review. It allows flexible selection of reviewers, by directory, filename, or regular expression.  Developers are strongly encouraged to add themselves as reviewers for areas that they are knowledgeable in.
 +
 
 +
For developers looking for reviewers, the [contrib/scripts/get_maintainer.pl|https://git.whamcloud.com/?p=fs/lustre-release.git;a=blob;f=contrib/scripts/get_maintainer.pl;hb=HEAD] script can be run against a file or patch to generate a list of reviewers. In addition to looking at the MAINTAINERS file, it will also search recent git commit history to find the list of people who have reviewed and modified this code the most. Since this is based on lines of code modified, it can sometimes be confused by patches that are making trivial changes (e.g. whitespace cleanup), so some discretion is needed when using the results.
 +
 
 +
The below list is kept for historical purposes until it can be merged into the MAINTAINERS file.
  
 
== Build System ==
 
== Build System ==
 
 
* Christopher J. Morrone (LLNL)
 
* Christopher J. Morrone (LLNL)
 
* Alex Lyashkov (Cray)
 
* Alex Lyashkov (Cray)
  
 
== ChangeLogs / llog ==
 
== ChangeLogs / llog ==
 
 
* Ben Evans (Cray)
 
* Ben Evans (Cray)
 
* Sergey Cheremencev (Cray)
 
* Sergey Cheremencev (Cray)
Line 28: Line 30:
  
 
== ldiskfs ==
 
== ldiskfs ==
 
 
* Artem Blagodarenko (Cray)
 
* Artem Blagodarenko (Cray)
* Andreas Dilger (Intel)
+
* Andreas Dilger (Whamcloud)
  
 
== ZFS ==
 
== ZFS ==
* Andreas Dilger (Intel)
+
* Andreas Dilger (Whamcloud)
  
 
== LLAPI / Interactions with userland ==
 
== LLAPI / Interactions with userland ==
 
 
* Henri Doreau (CEA)
 
* Henri Doreau (CEA)
 
* Thomas Leibovici (CEA)
 
* Thomas Leibovici (CEA)
Line 42: Line 42:
  
 
== LNDs==
 
== LNDs==
 
 
* Chris Horn (Cray)
 
* Chris Horn (Cray)
  
 
== LNet ==
 
== LNet ==
 
 
* Christopher J. Morrone (LLNL)
 
* Christopher J. Morrone (LLNL)
 
* Alex Lyashkov (Cray)
 
* Alex Lyashkov (Cray)
Line 52: Line 50:
  
 
== LDLM ==
 
== LDLM ==
 
 
* Patrick Farrell (Cray)
 
* Patrick Farrell (Cray)
 
* Alex Lyashkov (Cray)
 
* Alex Lyashkov (Cray)
Line 58: Line 55:
  
 
== NRS ==
 
== NRS ==
 
 
* Henri Doreau (CEA)
 
* Henri Doreau (CEA)
 
* Nikitas Angelinas (Cray)
 
* Nikitas Angelinas (Cray)
  
 
== OSC ==
 
== OSC ==
 
 
* Patrick Farrell (Cray)
 
* Patrick Farrell (Cray)
 
* Alex Lyashkov (Cray)
 
* Alex Lyashkov (Cray)
  
 
== OSD ==
 
== OSD ==
 
 
* Alex Lyashkov (Cray)
 
* Alex Lyashkov (Cray)
 
* Ben Evans (Cray)
 
* Ben Evans (Cray)
  
 
== Pools Feature ==
 
== Pools Feature ==
 
 
* Jacques-Charles Lafoucriere (CEA)
 
* Jacques-Charles Lafoucriere (CEA)
  
 
== Testing ==
 
== Testing ==
 
 
* Elena Gryaznova (Cray)
 
* Elena Gryaznova (Cray)
 
* Justin Miller (Cray)
 
* Justin Miller (Cray)

Revision as of 10:40, 25 November 2018

The following people are willing to perform code reviews on code in the listed sections.

In Lustre 2.12 and later, the [MAINTAINERS|https://git.whamcloud.com/?p=fs/lustre-release.git;a=blob;f=MAINTAINERS;hb=HEAD] file contains a list of developers that are available for code review. It allows flexible selection of reviewers, by directory, filename, or regular expression. Developers are strongly encouraged to add themselves as reviewers for areas that they are knowledgeable in.

For developers looking for reviewers, the [contrib/scripts/get_maintainer.pl|https://git.whamcloud.com/?p=fs/lustre-release.git;a=blob;f=contrib/scripts/get_maintainer.pl;hb=HEAD] script can be run against a file or patch to generate a list of reviewers. In addition to looking at the MAINTAINERS file, it will also search recent git commit history to find the list of people who have reviewed and modified this code the most. Since this is based on lines of code modified, it can sometimes be confused by patches that are making trivial changes (e.g. whitespace cleanup), so some discretion is needed when using the results.

The below list is kept for historical purposes until it can be merged into the MAINTAINERS file.

Build System

  • Christopher J. Morrone (LLNL)
  • Alex Lyashkov (Cray)

ChangeLogs / llog

  • Ben Evans (Cray)
  • Sergey Cheremencev (Cray)

General Cleanup (e.g., to/from upstream Linux staging)

  • Ben Evans (Cray)
  • James Simmons (ORNL)

HSM Feature

  • Jacques-Charles Lafoucriere (CEA)
  • Henri Doreau (CEA)
  • Ben Evans (Cray)
  • Nikitas Angelinas (Cray)

Kernel Patches

  • Patrick Farrell (Cray)

ldiskfs

  • Artem Blagodarenko (Cray)
  • Andreas Dilger (Whamcloud)

ZFS

  • Andreas Dilger (Whamcloud)

LLAPI / Interactions with userland

  • Henri Doreau (CEA)
  • Thomas Leibovici (CEA)
  • Andreas Dilger (Intel)

LNDs

  • Chris Horn (Cray)

LNet

  • Christopher J. Morrone (LLNL)
  • Alex Lyashkov (Cray)
  • Chris Horn (Cray)

LDLM

  • Patrick Farrell (Cray)
  • Alex Lyashkov (Cray)
  • Vitaly Fertman (Cray)

NRS

  • Henri Doreau (CEA)
  • Nikitas Angelinas (Cray)

OSC

  • Patrick Farrell (Cray)
  • Alex Lyashkov (Cray)

OSD

  • Alex Lyashkov (Cray)
  • Ben Evans (Cray)

Pools Feature

  • Jacques-Charles Lafoucriere (CEA)

Testing

  • Elena Gryaznova (Cray)
  • Justin Miller (Cray)
  • Jacques-Charles Lafoucriere (CEA)