Difference between revisions of "Code Reviewers"

From Lustre Wiki
Jump to navigation Jump to search
m (Fix URLs)
(Remove old reviewer links, the MAINTAINERS file should be used instead)
 
Line 1: Line 1:
  
In Lustre 2.12 and later, the [https://git.whamcloud.com/?p=fs/lustre-release.git;a=blob;f=MAINTAINERS;hb=HEAD MAINTAINERS] file contains a list of developers that are available for code review. It allows flexible selection of reviewers, by directory, filename, or regular expression.  Developers are strongly encouraged to add themselves as reviewers for areas that they are knowledgeable in.  
+
Since Lustre 2.12, the [https://git.whamcloud.com/?p=fs/lustre-release.git;a=blob;f=MAINTAINERS;hb=HEAD MAINTAINERS] file contains a list of developers that are available for code review. It allows flexible selection of reviewers, by directory, filename, or regular expression.  Developers are strongly encouraged to add themselves as reviewers for areas that they are knowledgeable in.  
  
For developers looking for reviewers, the [https://git.whamcloud.com/?p=fs/lustre-release.git;a=blob;f=contrib/scripts/get_maintainer.pl;hb=HEAD contrib/scripts/get_maintainer.pl] script can be run against a file or patch to generate a list of reviewers. In addition to looking at the MAINTAINERS file, it will also search recent git commit history to find the list of people who have reviewed and modified this code the most. Since this is based on lines of code modified, it can sometimes be confused by patches that are making trivial changes (e.g. whitespace cleanup), so some discretion is needed when using the results.  
+
For developers looking for reviewers, they can look at the [https://git.whamcloud.com/?p=fs/lustre-release.git;a=blob;f=MAINTAINERS;hb=HEAD MAINTAINERS] file, or run the [https://git.whamcloud.com/?p=fs/lustre-release.git;a=blob;f=contrib/scripts/get_maintainer.pl;hb=HEAD contrib/scripts/get_maintainer.pl] script against a specific file or patch to generate a list of reviewers. In addition to looking at the MAINTAINERS file, the get_maintainer.pl script will also search recent git commit history to find the list of people who have recently reviewed and/or modified this code the most. Since this is based on lines of code modified, it can sometimes be confused by patches that are making trivial changes (e.g. code style changes), so some discretion is needed when using the results.  
  
The following list of people are willing to perform code reviews on code in the listed sections.It  is kept for historical purposes until it can be merged into the MAINTAINERS file.
 
 
== Build System ==
 
* Christopher J. Morrone (LLNL)
 
* Alex Lyashkov (Cray)
 
 
== ChangeLogs / llog ==
 
* Ben Evans (Cray)
 
* Sergey Cheremencev (Cray)
 
 
== General Cleanup (e.g., to/from upstream Linux staging) ==
 
* Ben Evans (Cray)
 
* James Simmons (ORNL)
 
 
== HSM Feature ==
 
 
* Jacques-Charles Lafoucriere (CEA)
 
* Henri Doreau (CEA)
 
* Ben Evans (Cray)
 
* Nikitas Angelinas (Cray)
 
 
== Kernel Patches ==
 
* Patrick Farrell (Cray)
 
 
== ldiskfs ==
 
* Artem Blagodarenko (Cray)
 
* Andreas Dilger (Whamcloud)
 
 
== ZFS ==
 
* Andreas Dilger (Whamcloud)
 
 
== LLAPI / Interactions with userland ==
 
* Henri Doreau (CEA)
 
* Thomas Leibovici (CEA)
 
* Andreas Dilger (Intel)
 
 
== LNDs==
 
* Chris Horn (Cray)
 
 
== LNet ==
 
* Christopher J. Morrone (LLNL)
 
* Alex Lyashkov (Cray)
 
* Chris Horn (Cray)
 
 
== LDLM ==
 
* Patrick Farrell (Cray)
 
* Alex Lyashkov (Cray)
 
* Vitaly Fertman (Cray)
 
 
== NRS ==
 
* Henri Doreau (CEA)
 
* Nikitas Angelinas (Cray)
 
 
== OSC ==
 
* Patrick Farrell (Cray)
 
* Alex Lyashkov (Cray)
 
 
== OSD ==
 
* Alex Lyashkov (Cray)
 
* Ben Evans (Cray)
 
 
== Pools Feature ==
 
* Jacques-Charles Lafoucriere (CEA)
 
 
== Testing ==
 
* Elena Gryaznova (Cray)
 
* Justin Miller (Cray)
 
* Jacques-Charles Lafoucriere (CEA)
 
  
 
[[Category: Development]]
 
[[Category: Development]]

Latest revision as of 20:28, 16 June 2019

Since Lustre 2.12, the MAINTAINERS file contains a list of developers that are available for code review. It allows flexible selection of reviewers, by directory, filename, or regular expression. Developers are strongly encouraged to add themselves as reviewers for areas that they are knowledgeable in.

For developers looking for reviewers, they can look at the MAINTAINERS file, or run the contrib/scripts/get_maintainer.pl script against a specific file or patch to generate a list of reviewers. In addition to looking at the MAINTAINERS file, the get_maintainer.pl script will also search recent git commit history to find the list of people who have recently reviewed and/or modified this code the most. Since this is based on lines of code modified, it can sometimes be confused by patches that are making trivial changes (e.g. code style changes), so some discretion is needed when using the results.