Code Reviewers: Difference between revisions

From Lustre Wiki
Jump to navigation Jump to search
(Add self as a potential reviewer for NRS patches)
(Remove old reviewer links, the MAINTAINERS file should be used instead)
 
(15 intermediate revisions by 7 users not shown)
Line 1: Line 1:
The following people are willing to perform code reviews on code in the listed sections.


Please add yourself to a section if you are willing to engage in code reviews in the subsection of Lustre code.
Since Lustre 2.12, the [https://git.whamcloud.com/?p=fs/lustre-release.git;a=blob;f=MAINTAINERS;hb=HEAD MAINTAINERS] file contains a list of developers that are available for code review. It allows flexible selection of reviewers, by directory, filename, or regular expression.  Developers are strongly encouraged to add themselves as reviewers for areas that they are knowledgeable in.  


== Build System ==
For developers looking for reviewers, they can look at the [https://git.whamcloud.com/?p=fs/lustre-release.git;a=blob;f=MAINTAINERS;hb=HEAD MAINTAINERS] file, or run the [https://git.whamcloud.com/?p=fs/lustre-release.git;a=blob;f=contrib/scripts/get_maintainer.pl;hb=HEAD contrib/scripts/get_maintainer.pl] script against a specific file or patch to generate a list of reviewers. In addition to looking at the MAINTAINERS file, the get_maintainer.pl script will also search recent git commit history to find the list of people who have recently reviewed and/or modified this code the most. Since this is based on lines of code modified, it can sometimes be confused by patches that are making trivial changes (e.g. code style changes), so some discretion is needed when using the results.


* Christopher J. Morrone (LLNL)
* Alex Lyashkov (Seagate)


== General Cleanup (e.g., from upstream Linux staging) ==
[[Category: Development]]
 
== HSM Feature ==
 
* Jacques-Charles Lafoucriere (CEA)
* Henri Doreau (CEA)
 
== Kernel Patches ==
 
== ldiskfs ==
 
== LNDs==
 
* Chris Horn (Cray)
 
== LNet ==
 
* Christopher J. Morrone (LLNL)
* Alex Lyashkov (Seagate)
* Chris Horn (Cray)
 
== LDLM ==
 
* Patrick Farrell (Cray)
* Alex Lyashkov (Seagate)
 
== NRS ==
 
* Henri Doreau (CEA)
 
== OSC ==
 
* Patrick Farrell (Cray)
* Alex Lyashkov (Seagate)
 
== OSD ==
 
* Alex Lyashkov (Seagate)
 
== Pools Feature ==
 
* Jacques-Charles Lafoucriere (CEA)
 
== Testing ==
 
* Elena Gryaznova (Seagate)
* Justin Miller (Cray)
* Jacques-Charles Lafoucriere (CEA)

Latest revision as of 20:28, 16 June 2019

Since Lustre 2.12, the MAINTAINERS file contains a list of developers that are available for code review. It allows flexible selection of reviewers, by directory, filename, or regular expression. Developers are strongly encouraged to add themselves as reviewers for areas that they are knowledgeable in.

For developers looking for reviewers, they can look at the MAINTAINERS file, or run the contrib/scripts/get_maintainer.pl script against a specific file or patch to generate a list of reviewers. In addition to looking at the MAINTAINERS file, the get_maintainer.pl script will also search recent git commit history to find the list of people who have recently reviewed and/or modified this code the most. Since this is based on lines of code modified, it can sometimes be confused by patches that are making trivial changes (e.g. code style changes), so some discretion is needed when using the results.