Difference between revisions of "Lustre Manual Changes"

From Lustre Wiki
Jump to navigation Jump to search
m
m
Line 77: Line 77:
 
git checkout -b b_new_change; vi XXXX.xml
 
git checkout -b b_new_change; vi XXXX.xml
 
</pre>
 
</pre>
Vim has syntax highlighting, as does emacs. Limited success has been reported with WYSIWYG XML editors.
+
A few notes regarding edits:
 
+
*Vim has syntax highlighting, as does emacs. Limited success has been reported with WYSIWYG XML editors.
If using a WYSIWYG editor, run "git diff" to ensure it didn't reformat the whole .xml file and that only the intended text was modified.
+
*If using a WYSIWYG editor, run "git diff" to ensure it didn't reformat the whole .xml file and that only the intended text was modified.
 
+
*Text should be wrapped at 80 columns so that it is easier to comment on changes during review. Otherwise, it is difficult to make specific comments on an issue after a whole long paragraph of text that is a single line in the .xml document.
Text should be wrapped at 80 columns so that it is easier to comment on changes during review. Otherwise, it is difficult to make specific comments on an issue after a whole long paragraph of text that is a single line in the .xml document
+
*Ensure you are familiar with [[Change Review Guidelines]] specified in this document so that you understand the writing criteria reviewers will apply to qualify your change.
 
 
Ensure you are familiar with the guidance for manual reviewers specified in this document so that you understand the writing criteria reviewers will apply to qualify your change.
 
  
 
;Check that the document still validates:
 
;Check that the document still validates:
Line 187: Line 185:
 
[https://wiki.whamcloud.com/display/PUB/Using+Gerrit Using Gerrit] describes how to submit changes to the manual. Criteria for manual changes to land a change on master is: +2 (+1 from two human reviewers) and +1 verified from Jenkins.
 
[https://wiki.whamcloud.com/display/PUB/Using+Gerrit Using Gerrit] describes how to submit changes to the manual. Criteria for manual changes to land a change on master is: +2 (+1 from two human reviewers) and +1 verified from Jenkins.
  
= Reviewing a Change =
+
= Change Review Guidelines =
 
Like code, Manual changes are submitted to a review process. All the manual [http://review.whamcloud.com/#/q/project:doc/manual patches that are in Gerrit for review can be seen].  Logged-in users can review previous versions of the Manual. Updates to the Manual are automatically built from the change and available as a [http://build.whamcloud.com/job/lustre-manual-reviews/ review Manual build], links to these builds are in the comments of a change. Reviewers are advised to read the guidance for Manual reviewers in this section.
 
Like code, Manual changes are submitted to a review process. All the manual [http://review.whamcloud.com/#/q/project:doc/manual patches that are in Gerrit for review can be seen].  Logged-in users can review previous versions of the Manual. Updates to the Manual are automatically built from the change and available as a [http://build.whamcloud.com/job/lustre-manual-reviews/ review Manual build], links to these builds are in the comments of a change. Reviewers are advised to read the guidance for Manual reviewers in this section.
  
 
[[Category:Howto]]
 
[[Category:Howto]]

Revision as of 08:00, 25 June 2018


UNDER CONSTRUCTION 06/20/2018

Lustre includes an extensive manual. This is developed much like the source code: anyone can submit patches, review changes and suggest improvements. The manual workflow includes Gerrit and "continuous integration" practice. This enables changes to be automatically verified and conveniently reviewed using Gerrit.

Requesting a Change or Improvement

Manual corrections and enhancements are tracked in the same manor as code changes. A Jira project exists, LUDOC, where the changes created and tracked. LUDOC tickets can be created, updated or commented by anyone with an account on [1]. Once you have an account, go to JIRA and create your LUDOC ticket:

https://jira.whamcloud.com/browse/LUDOC/

Minor changes

Minor changes and fixes can be committed against the existing LUDOC-11 issue. The intention is to minimize the overhead for quick fixes. For such a change, your commit message may be:

LUDOC-11 quota: spelling corrections
Brief description of the change if it is more extensive.
Signed-off-by: Random User <[email protected]>

Submitting a Change to the Manual Source

Anyone can create changes that modify the current Lustre manual. The manual is written in Docbook XML version 5, which each chapter residing in a separate xml file. Reference material is readily available on the web for Docbook XML syntax.

Development Environment Setup

Docbook 5 development environment has been tested with Ubuntu 18.04, RHEL7 Linux, as well as Mac OS X. The auto build process occurs on RHEL7. The original development work for the manual was completed using Ubuntu.

Ubuntu 18.04

Install the following packages (last validated 2018-06-20): apt install make git libxml2-utils xsltproc fop docbook5-xml docbook-xsl-ns

RHEL 7

Install the following packages: yum install fop libxml2 libxslt docbook5-style-xsl docbook5-schema docbook5-schemas deja*

Install from EPEL, CentOS, source or Whamcloud toolkit: yum localinstall fop xmlgraphics-commons-1.4-3

fop and xmlgraphics

  • A suitably recent version of fop (>= 1.0) is available for EL7 from Whamcloud toolkit in the 'x86_64' folder.
  • A suitably recent version xmlgraphics-commons to provide dependencies on fop >= 1.0 is a available for EL7 from Whamcloud toolkit in the 'noarch' folder.

Fedora 18

Install the following packages: yum install libxml2 libxslt fop docbook5-style-xsl docbook5-schemas docbook5-schemas

Max OS X

It is possible to use either the MacPorts or Homebrew (Brew) package managers on Mac OS X to install the required 3rd-party DocBook tools, instead of compiling them yourself. Only one of these two package managers should be used at one time.

If using the MacPorts package, install the following packages: sudo port install libxml2 libxslt fop docbook-xml-5.0 docbook-xsl

You may experience problems if you don't use MacPorts. These problems typically can be resolved by editing the Makefile to give the correct path to 'docbookxi.rng'.

If using Brew install following packages: brew install libxml2 libxslt fop docbook docbook-xsl

Changing the Manual

The manual is controlled with Jira with git and Gerrit (details below). The general workflow is:

Clone the manual from the "doc/manual" repository
git clone git://git.whamcloud.com/doc/manual lustre-manual
Make change in a local branch, editing .xml files as needed
git checkout -b b_new_change; vi XXXX.xml

A few notes regarding edits:

  • Vim has syntax highlighting, as does emacs. Limited success has been reported with WYSIWYG XML editors.
  • If using a WYSIWYG editor, run "git diff" to ensure it didn't reformat the whole .xml file and that only the intended text was modified.
  • Text should be wrapped at 80 columns so that it is easier to comment on changes during review. Otherwise, it is difficult to make specific comments on an issue after a whole long paragraph of text that is a single line in the .xml document.
  • Ensure you are familiar with Change Review Guidelines specified in this document so that you understand the writing criteria reviewers will apply to qualify your change.
Check that the document still validates
make check
Build a target (i.e. html or pdf) and visually check that the document looks good
make pdf
open lustre_manual.pdf
Commit the change locally
git commit -a -v -s
Push the change for review
make push

Note: 'make push' simply calls git push ssh://review.whamcloud.com:29418/doc/manual HEAD:refs/for/master

Add two inspectors to the manual
someone with a technical background related to the changes and someone for style/English.

Verify the Docbook

Docbook 5 is verfied using a relaxNG schema with schematron rules. The Manual is build using separate xml files for each chapter which uses XInclude elements. Two complementary tools support relaxNG schemas with XInclude. The tools can be used together to identify problems, and they are xmllint and jing. The easiest way to verify the changes are valid XML is to use the make check target:

make check
  • This will internally verify with xmllint the ./index.xml of doc/manual.
  • OPTIONAL additional verification with jing the ./index.xml of doc/manual:

Fixing Problems

If make check fails, an error will be reported. Finding the source of the problem can be tricky if incorrectly positioned tags are the problem, i.e. a misplaced <section>. In this case, experience suggests that the problem may be below the indicated problem in the returned error.

Building The Manual

Docbook manuals can be transformed into a number of formats automatically. Two formats of interest are HTML and PDF. HTML transforms can be made directly from the Docbook xml (with xsltproc). PDF transforms require transforming first into an intermediatory fop xml format, and then into a PDF with a tool called fop. The easiest way to generate the output files is via the make targets:

To build a HTML version of the manual
make html
Similarly, to build a PDF version of the manual
make pdf

Building a xhtml and epub version of the manual is also supported by the makefile.

Debugging

There are two types of errors that are common:

  1. well formed xml
    'make check' will do a good job of discovering and precisely identifying the location of these types of errors.
  2. valid xml
    'make check' will validate the xml but does a poor job of identifying errors when they occur. The first complication is that xinclude is used to include separate xml files. As a result, xmllint is unable to really spot where the problem is.
Example
$ make check
xmllint --noout --xinclude --noent --relaxng /usr/share/xml/docbook5/schema/rng/5.0/docbookxi.rng ./index.xml
./index.xml:6: element itemizedlist: Relax-NG validity error : Expecting an element listitem, got nothing
./index.xml:6: element itemizedlist: Relax-NG validity error : Expecting element example, got itemizedlist
./index.xml:63: element section: Relax-NG validity error : Element chapter has extra content: section
./index.xml:1: element chapter: Relax-NG validity error : Did not expect element chapter there
./index.xml:1: element chapter: Relax-NG validity error : Expecting element include, got chapter
./index.xml fails to validate

This complication can be avoided by first flattening the manual into a single xml file:

$ xmllint  --xinclude  index.xml  >  /tmp/resolved.xml

Now, you can get a slightly better idea of where the problem is using xmllint – but it's still not that great:

$ xmllint --noout --xinclude --noent --relaxng /usr/share/xml/docbook5/schema/rng/5.0/docbookxi.rng /tmp/resolved.xml
/tmp/resolved.xml:8757: element itemizedlist: Relax-NG validity error : Expecting an element listitem, got nothing
/tmp/resolved.xml:8757: element itemizedlist: Relax-NG validity error : Expecting element example, got itemizedlist
/tmp/resolved.xml:8812: element section: Relax-NG validity error : Element chapter has extra content: section
/tmp/resolved.xml:8752: element chapter: Relax-NG validity error : Did not expect element chapter there
/tmp/resolved.xml:8752: element chapter: Relax-NG validity error : Expecting element include, got chapter
/tmp/resolved.xml fails to validate

However, if you have Jing installed, you can get an even better idea of what the problem is - as well as where it is:

$ jing /usr/share/xml/docbook5/schema/rng/5.0/docbookxi.rng /tmp/resolved.xml 
/tmp/resolved.xml:9127:29: error: element "para" not allowed here; expected the element end-tag, text or element "abbrev", "accel", "acronym", "address", "alt", "anchor", "annotation", "application", "author", "bibliolist", "biblioref", "blockquote", "bridgehead", "calloutlist", "caution", "citation", "citebiblioid", "citerefentry", "citetitle", "classname", "classsynopsis", "cmdsynopsis", "code", "command", "computeroutput", "constant", "constraintdef", "constructorsynopsis", "coref", "database", "date", "destructorsynopsis", "editor", "email", "emphasis", "envar", "epigraph", "equation", "errorcode", "errorname", "errortext", "errortype", "example", "exceptionname", "fieldsynopsis", "figure", "filename", "firstterm", "footnote", "footnoteref", "foreignphrase", "funcsynopsis", "function", "glosslist", "glossterm", "guibutton", "guiicon", "guilabel", "guimenu", "guimenuitem", "guisubmenu", "hardware", "important", "indexterm", "informalequation", "informalexample", "informalfigure", "informaltable", "initializer", "inlineequation", "inlinemediaobject", "interfacename", "itemizedlist", "jobtitle", "keycap", "keycode", "keycombo", "keysym", "link", "literal", "literallayout", "markup", "mediaobject", "menuchoice", "methodname", "methodsynopsis", "modifier", "mousebutton", "msgset", "nonterminal", "note", "olink", "ooclass", "ooexception", "oointerface", "option", "optional", "orderedlist", "org", "orgname", "package", "parameter", "person", "personname", "phrase", "procedure", "productionset", "productname", "productnumber", "programlisting", "programlistingco", "prompt", "property", "qandaset", "quote", "remark", "replaceable", "returnvalue", "revhistory", "screen", "screenco", "screenshot", "segmentedlist", "shortcut", "sidebar", "simplelist", "subscript", "superscript", "symbol", "synopsis", "systemitem", "table", "tag", "task", "termdef", "tip", "token", "trademark", "type", "uri", "userinput", "variablelist", "varname", "warning", "wordasword", "xi:include" or "xref"

Other Tools

Jira

Jira has a project specifically for Manual changes: LUDOC.

Git
  • Clone the manual as follows:
git clone git://git.whamcloud.com/doc/manual lustre-manual
  • Push changes for review:
make push

Internally this does something like:

git push ssh://[email protected]:29418/doc/manual HEAD:refs/for/master
Gerrit

Using Gerrit describes how to submit changes to the manual. Criteria for manual changes to land a change on master is: +2 (+1 from two human reviewers) and +1 verified from Jenkins.

Change Review Guidelines

Like code, Manual changes are submitted to a review process. All the manual patches that are in Gerrit for review can be seen. Logged-in users can review previous versions of the Manual. Updates to the Manual are automatically built from the change and available as a review Manual build, links to these builds are in the comments of a change. Reviewers are advised to read the guidance for Manual reviewers in this section.